aboutsummaryrefslogtreecommitdiff
path: root/target-s390x
diff options
context:
space:
mode:
authorThomas Huth <thuth@linux.vnet.ibm.com>2013-07-02 14:45:16 +0200
committerChristian Borntraeger <borntraeger@de.ibm.com>2013-07-30 16:12:25 +0200
commitd2ee774616280db778f0b4b97a8ac514602ad52c (patch)
tree9b162d757733f5227fa3dc77e6ca9b17158b6d1e /target-s390x
parentc1e8dfb5e860c48adf5026a5a7cf8f35be66c22c (diff)
downloadqemu-d2ee774616280db778f0b4b97a8ac514602ad52c.zip
qemu-d2ee774616280db778f0b4b97a8ac514602ad52c.tar.gz
qemu-d2ee774616280db778f0b4b97a8ac514602ad52c.tar.bz2
s390x/kvm: Remove redundant return code
Removed the redundant return code statement from handle_instruction() - it always returned 0 and never reports any errors to its caller, since errors from the sub-functions are already reported via program exceptions instead. Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Diffstat (limited to 'target-s390x')
-rw-r--r--target-s390x/kvm.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index eff8d28..26d18e3 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -693,7 +693,7 @@ out:
return 0;
}
-static int handle_instruction(S390CPU *cpu, struct kvm_run *run)
+static void handle_instruction(S390CPU *cpu, struct kvm_run *run)
{
unsigned int ipa0 = (run->s390_sieic.ipa & 0xff00);
uint8_t ipa1 = run->s390_sieic.ipa & 0x00ff;
@@ -719,7 +719,6 @@ static int handle_instruction(S390CPU *cpu, struct kvm_run *run)
if (r < 0) {
enter_pgmcheck(cpu, 0x0001);
}
- return 0;
}
static bool is_special_wait_psw(CPUState *cs)
@@ -739,7 +738,7 @@ static int handle_intercept(S390CPU *cpu)
(long)cs->kvm_run->psw_addr);
switch (icpt_code) {
case ICPT_INSTRUCTION:
- r = handle_instruction(cpu, run);
+ handle_instruction(cpu, run);
break;
case ICPT_WAITPSW:
/* disabled wait, since enabled wait is handled in kernel */