diff options
author | Michael S. Tsirkin <mst@redhat.com> | 2014-08-17 11:45:17 +0200 |
---|---|---|
committer | Luiz Capitulino <lcapitulino@redhat.com> | 2014-08-18 14:39:10 -0400 |
commit | b3dd1b8c295636e64ceb14cdc4db6420d7319e38 (patch) | |
tree | e8455dfc57b74258a99088394bf2c6ba9a57ed40 /stubs | |
parent | 2928207ac1bb2751a1554ea0f9a9641179f51488 (diff) | |
download | qemu-b3dd1b8c295636e64ceb14cdc4db6420d7319e38.zip qemu-b3dd1b8c295636e64ceb14cdc4db6420d7319e38.tar.gz qemu-b3dd1b8c295636e64ceb14cdc4db6420d7319e38.tar.bz2 |
monitor: fix use after free
The function monitor_fdset_dup_fd_find_remove() references member of
'mon_fdset' which - when remove flag is set - may be freed in function
monitor_fdset_cleanup().
remove is set by monitor_fdset_dup_fd_remove which in practice
does not need the returned value, so make it void,
and return -1 from monitor_fdset_dup_fd_find_remove.
Reported-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'stubs')
-rw-r--r-- | stubs/fdset-remove-fd.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/stubs/fdset-remove-fd.c b/stubs/fdset-remove-fd.c index b3886d9..7f6d61e 100644 --- a/stubs/fdset-remove-fd.c +++ b/stubs/fdset-remove-fd.c @@ -1,7 +1,6 @@ #include "qemu-common.h" #include "monitor/monitor.h" -int monitor_fdset_dup_fd_remove(int dupfd) +void monitor_fdset_dup_fd_remove(int dupfd) { - return -1; } |