diff options
| author | Fiona Ebner <f.ebner@proxmox.com> | 2024-07-10 17:25:29 +0200 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2024-07-16 18:18:24 +0200 |
| commit | 57a8a80d1a5b28797b21d30bfc60601945820e51 (patch) | |
| tree | 4751982bb7f2c9871db762bc227bc98cfb63fe6f /scripts | |
| parent | a4975023fb13cf229bd59c9ceec1b8cbdc5b9a20 (diff) | |
| download | qemu-57a8a80d1a5b28797b21d30bfc60601945820e51.zip qemu-57a8a80d1a5b28797b21d30bfc60601945820e51.tar.gz qemu-57a8a80d1a5b28797b21d30bfc60601945820e51.tar.bz2 | |
scsi: fix regression and honor bootindex again for legacy drives
Commit 3089637461 ("scsi: Don't ignore most usb-storage properties")
removed the call to object_property_set_int() and thus the 'set'
method for the bootindex property was also not called anymore. Here
that method is device_set_bootindex() (as configured by
scsi_dev_instance_init() -> device_add_bootindex_property()) which as
a side effect registers the device via add_boot_device_path().
As reported by a downstream user [0], the bootindex property did not
have the desired effect anymore for legacy drives. Fix the regression
by explicitly calling the add_boot_device_path() function after
checking that the bootindex is not yet used (to avoid
add_boot_device_path() calling exit()).
[0]: https://forum.proxmox.com/threads/149772/post-679433
Cc: qemu-stable@nongnu.org
Fixes: 3089637461 ("scsi: Don't ignore most usb-storage properties")
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Link: https://lore.kernel.org/r/20240710152529.1737407-1-f.ebner@proxmox.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions