aboutsummaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorJohn Snow <jsnow@redhat.com>2020-10-09 12:15:57 -0400
committerMarkus Armbruster <armbru@redhat.com>2020-10-10 11:37:49 +0200
commit2cc1eefb84c9608661889f4deffe89f1c9aef6bb (patch)
tree76b5358c66dec7b5cc43f109850ef0144cb565a6 /scripts
parent554df4f33f2076f973b4ae6bc55b5160f513634f (diff)
downloadqemu-2cc1eefb84c9608661889f4deffe89f1c9aef6bb.zip
qemu-2cc1eefb84c9608661889f4deffe89f1c9aef6bb.tar.gz
qemu-2cc1eefb84c9608661889f4deffe89f1c9aef6bb.tar.bz2
qapi/visit.py: remove unused parameters from gen_visit_object
And this fixes the pylint report for this file, so make sure we check this in the future, too. Signed-off-by: John Snow <jsnow@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Cleber Rosa <crosa@redhat.com> Tested-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20201009161558.107041-36-jsnow@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'scripts')
-rw-r--r--scripts/qapi/pylintrc1
-rw-r--r--scripts/qapi/visit.py4
2 files changed, 2 insertions, 3 deletions
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index b3c4cf4..b9e077a 100644
--- a/scripts/qapi/pylintrc
+++ b/scripts/qapi/pylintrc
@@ -6,7 +6,6 @@ ignore-patterns=error.py,
expr.py,
parser.py,
schema.py,
- visit.py,
[MESSAGES CONTROL]
diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py
index e00f2a0..8699e5c 100644
--- a/scripts/qapi/visit.py
+++ b/scripts/qapi/visit.py
@@ -250,7 +250,7 @@ out_obj:
return ret
-def gen_visit_object(name, base, members, variants):
+def gen_visit_object(name):
return mcgen('''
bool visit_type_%(c_name)s(Visitor *v, const char *name,
@@ -343,7 +343,7 @@ class QAPISchemaGenVisitVisitor(QAPISchemaModularCVisitor):
if not name.startswith('q_'):
# only explicit types need an allocating visit
self._genh.add(gen_visit_decl(name))
- self._genc.add(gen_visit_object(name, base, members, variants))
+ self._genc.add(gen_visit_object(name))
def visit_alternate_type(self, name, info, ifcond, features, variants):
with ifcontext(ifcond, self._genh, self._genc):