aboutsummaryrefslogtreecommitdiff
path: root/scripts/shaderinclude.py
diff options
context:
space:
mode:
authorZhao Liu <zhao1.liu@intel.com>2023-10-23 17:46:34 +0800
committerMichael S. Tsirkin <mst@redhat.com>2023-11-07 03:39:11 -0500
commit198eee0cc17d74f17ecd54ddf72681f421f7bc43 (patch)
treef670b5638692fda73c34b120dfa4efb9bf127718 /scripts/shaderinclude.py
parent7cb953ca1956d4ac5d8ad798321fe3fde765befc (diff)
downloadqemu-198eee0cc17d74f17ecd54ddf72681f421f7bc43.zip
qemu-198eee0cc17d74f17ecd54ddf72681f421f7bc43.tar.gz
qemu-198eee0cc17d74f17ecd54ddf72681f421f7bc43.tar.bz2
tests: bios-tables-test: Add test for smbios type4 thread count2
This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in type4"). In smbios_build_type_4_table() (hw/smbios/smbios.c), if the number of threads in the socket is more than 255, then smbios type4 table encodes threads per socket into the thread count2 field. So for the topology in this case, there're the following considerations: 1. threads per socket should be more than 255 to ensure we could cover the thread count2 field. 2. The original bug was that threads per socket was miscalculated, so now we should configure as many topology levels as possible (multiple dies, no module since x86 hasn't supported it) to cover more general topology scenarios, to ensure that the threads per socket encoded in the thread count2 field is correct. 3. For the more general topology, we should also add "cpus" (presented threads for machine) and "maxcpus" (total threads for machine) to make sure that configuring unpluged CPUs in smp (cpus < maxcpus) does not affect the correctness of threads per socket for thread count2 field. Note we don't consider the topology with multiple sockets since this topology would create too many vCPUs (more than 255 threads per socket with at least 2 sockets, which may cause the failure "Number of hotpluggable cpus requested (*) exceeds the maximum cpus supported by KVM (*) socket_accept failed: Resource temporarily unavailable"), and the calculation of threads per socket has already been covered by "thread count" test case. Based on these considerations, select the topology as the follow: -smp cpus=210,maxcpus=260,dies=2,cores=65,threads=2 The expected thread count2 = threads per socket = threads (2) * cores (65) * dies (2) = 260. Suggested-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: Zhao Liu <zhao1.liu@intel.com> Message-Id: <20231023094635.1588282-16-zhao1.liu@linux.intel.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'scripts/shaderinclude.py')
0 files changed, 0 insertions, 0 deletions