diff options
author | John Snow <jsnow@redhat.com> | 2025-09-03 01:06:30 -0400 |
---|---|---|
committer | John Snow <jsnow@redhat.com> | 2025-09-15 14:36:01 -0400 |
commit | 85f223e5b031eb8ab63fbca314a4fb296a3a2632 (patch) | |
tree | 2fed2e9f9a9cf20aaf6fbdd53eeca31a589272ec /scripts/qapi/expr.py | |
parent | 5d99044d09db0fa8c2b3294e301927118f9effc9 (diff) | |
download | qemu-85f223e5b031eb8ab63fbca314a4fb296a3a2632.zip qemu-85f223e5b031eb8ab63fbca314a4fb296a3a2632.tar.gz qemu-85f223e5b031eb8ab63fbca314a4fb296a3a2632.tar.bz2 |
python: backport 'avoid creating additional event loops per thread'
This commit is two backports squashed into one to avoid regressions.
python: *really* remove get_event_loop
A prior commit, aa1ff990, switched away from using get_event_loop *by
default*, but this is not good enough to avoid deprecation warnings as
`asyncio.get_event_loop_policy().get_event_loop()` is *also*
deprecated. Replace this mechanism with explicit calls to
asyncio.get_new_loop() and revise the cleanup mechanisms in __del__ to
match.
python: avoid creating additional event loops per thread
"Too hasty by far!", commit 21ce2ee4 attempted to avoid deprecated
behavior altogether by calling new_event_loop() directly if there was no
loop currently running, but this has the unfortunate side effect of
potentially creating multiple event loops per thread if tests
instantiate multiple QMP connections in a single thread. This behavior
is apparently not well-defined and causes problems in some, but not all,
combinations of Python interpreter version and platform environment.
Partially revert to Daniel Berrange's original patch, which calls
get_event_loop and simply suppresses the deprecation warning in
Python<=3.13. This time, however, additionally register new loops
created with new_event_loop() so that future calls to get_event_loop()
will return the loop already created.
Reported-by: Richard W.M. Jones <rjones@redhat.com>
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
cherry picked from commit python-qemu-qmp@21ce2ee4f2df87efe84a27b9c5112487f4670622
cherry picked from commit python-qemu-qmp@c08fb82b38212956ccffc03fc6d015c3979f42fe
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'scripts/qapi/expr.py')
0 files changed, 0 insertions, 0 deletions