diff options
| author | Igor Mammedov <imammedo@redhat.com> | 2025-09-22 15:26:00 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2025-10-05 09:01:08 -0400 |
| commit | b10166b104fad54d5d79024beafe1bcfe8a35c4a (patch) | |
| tree | 08124a9ef0e7aeffa6d723fbdb93f45748840f1b /scripts/lib/kdoc/kdoc_parser.py | |
| parent | 676757e50ce0ce206969b02dc2433c9e825e55f5 (diff) | |
| download | qemu-b10166b104fad54d5d79024beafe1bcfe8a35c4a.zip qemu-b10166b104fad54d5d79024beafe1bcfe8a35c4a.tar.gz qemu-b10166b104fad54d5d79024beafe1bcfe8a35c4a.tar.bz2 | |
x86: ich9: fix default value of 'No Reboot' bit in GCS
[2] initialized 'No Reboot' bit to 1 by default. And due to quirk it happened
to work with linux iTCO_wdt driver (which clears it on module load).
However spec [1] states:
"
R/W. This bit is set when the “No Reboot” strap (SPKR pin on
ICH9) is sampled high on PWROK.
"
So it should be set only when '-global ICH9-LPC.noreboot=true' and cleared
when it's false (which should be default).
Fix it to behave according to spec and set 'No Reboot' bit only when
'-global ICH9-LPC.noreboot=true'.
1)
Intel I/O Controller Hub 9 (ICH9) Family Datasheet (rev: 004)
2)
Fixes: 920557971b6 (ich9: add TCO interface emulation)
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20250922132600.562193-1-imammedo@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'scripts/lib/kdoc/kdoc_parser.py')
0 files changed, 0 insertions, 0 deletions