diff options
| author | Michal Privoznik <mprivozn@redhat.com> | 2025-01-07 15:52:07 +0100 |
|---|---|---|
| committer | Konstantin Kostiuk <kkostiuk@redhat.com> | 2025-02-26 13:34:25 +0200 |
| commit | c6f5dd7ac8ef62dcdec4cdeda1467c658161afff (patch) | |
| tree | 3699832abed0e44c05e6e0d0833f2a75fd8faf36 /rust/qemu-api/tests/tests.rs | |
| parent | 5b567c21c6d517beeb1087399f733662d7e8ff62 (diff) | |
| download | qemu-c6f5dd7ac8ef62dcdec4cdeda1467c658161afff.zip qemu-c6f5dd7ac8ef62dcdec4cdeda1467c658161afff.tar.gz qemu-c6f5dd7ac8ef62dcdec4cdeda1467c658161afff.tar.bz2 | |
qga: Don't daemonize before channel is initialized
If the agent is set to daemonize but for whatever reason fails to
init the channel, the error message is lost. Worse, the agent
daemonizes needlessly and returns success. For instance:
# qemu-ga -m virtio-serial \
-p /dev/nonexistent_device \
-f /run/qemu-ga.pid \
-t /run \
-d
# echo $?
0
This makes it needlessly hard for init scripts to detect a
failure in qemu-ga startup. Though, they shouldn't pass '-d' in
the first place.
Let's open the channel first and only after that become a daemon.
Related bug: https://bugs.gentoo.org/810628
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Message-ID: <7a42b0cbda5c7e01cf76bc1b29a1210cd018fa78.1736261360.git.mprivozn@redhat.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Diffstat (limited to 'rust/qemu-api/tests/tests.rs')
0 files changed, 0 insertions, 0 deletions