aboutsummaryrefslogtreecommitdiff
path: root/rust/qemu-api/src
diff options
context:
space:
mode:
authorJakub Jelen <jjelen@redhat.com>2024-11-13 12:55:23 +0000
committerKevin Wolf <kwolf@redhat.com>2024-11-25 11:03:42 +0100
commitfbdea3d6c13d5a75895c287a004c6f1a6bf6c164 (patch)
tree97045604db652517bef97818a57e7604d8596339 /rust/qemu-api/src
parent11bf1d6aa06138e93b274e942d6992af63ffc510 (diff)
downloadqemu-fbdea3d6c13d5a75895c287a004c6f1a6bf6c164.zip
qemu-fbdea3d6c13d5a75895c287a004c6f1a6bf6c164.tar.gz
qemu-fbdea3d6c13d5a75895c287a004c6f1a6bf6c164.tar.bz2
ssh: Do not switch session to non-blocking mode
The libssh does not handle non-blocking mode in SFTP correctly. The driver code already changes the mode to blocking for the SFTP initialization, but for some reason changes to non-blocking mode. This used to work accidentally until libssh in 0.11 branch merged the patch to avoid infinite looping in case of network errors: https://gitlab.com/libssh/libssh-mirror/-/merge_requests/498 Since then, the ssh driver in qemu fails to read files over SFTP as the first SFTP messages exchanged after switching the session to non-blocking mode return SSH_AGAIN, but that message is lost int the SFTP internals and interpretted as SSH_ERROR, which is returned to the caller: https://gitlab.com/libssh/libssh-mirror/-/issues/280 This is indeed an issue in libssh that we should address in the long term, but it will require more work on the internals. For now, the SFTP is not supported in non-blocking mode. Fixes: https://gitlab.com/libssh/libssh-mirror/-/issues/280 Signed-off-by: Jakub Jelen <jjelen@redhat.com> Signed-off-by: Richard W.M. Jones <rjones@redhat.com> Message-ID: <20241113125526.2495731-1-rjones@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'rust/qemu-api/src')
0 files changed, 0 insertions, 0 deletions