diff options
author | Gavin Shan <gshan@redhat.com> | 2021-10-15 20:42:46 +0800 |
---|---|---|
committer | Richard Henderson <richard.henderson@linaro.org> | 2021-10-20 16:26:19 -0700 |
commit | 99abb72520cb27f2318908831abc6915e286158b (patch) | |
tree | 12ee2604d0c93474036346b4ee0f0cf7d41bf7fc /roms | |
parent | 47432863ff1892870730e78630b5d0dbed7e72b2 (diff) | |
download | qemu-99abb72520cb27f2318908831abc6915e286158b.zip qemu-99abb72520cb27f2318908831abc6915e286158b.tar.gz qemu-99abb72520cb27f2318908831abc6915e286158b.tar.bz2 |
hw/arm/virt: Don't create device-tree node for empty NUMA node
The empty NUMA node, where no memory resides, are allowed. For
example, the following command line specifies two empty NUMA nodes.
With this, QEMU fails to boot because of the conflicting device-tree
node names, as the following error message indicates.
/home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 \
-accel kvm -machine virt,gic-version=host \
-cpu host -smp 4,sockets=2,cores=2,threads=1 \
-m 1024M,slots=16,maxmem=64G \
-object memory-backend-ram,id=mem0,size=512M \
-object memory-backend-ram,id=mem1,size=512M \
-numa node,nodeid=0,cpus=0-1,memdev=mem0 \
-numa node,nodeid=1,cpus=2-3,memdev=mem1 \
-numa node,nodeid=2 \
-numa node,nodeid=3
:
qemu-system-aarch64: FDT: Failed to create subnode /memory@80000000: FDT_ERR_EXISTS
As specified by linux device-tree binding document, the device-tree
nodes for these empty NUMA nodes shouldn't be generated. However,
the corresponding NUMA node IDs should be included in the distance
map. The memory hotplug through device-tree on ARM64 isn't existing
so far and it's not necessary to require the user to provide a distance
map. Furthermore, the default distance map Linux generates may even be
sufficient. So this simply skips populating the device-tree nodes for
these empty NUMA nodes to avoid the error, so that QEMU can be started
successfully.
Signed-off-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Message-Id: <20211015124246.23073-1-gshan@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'roms')
0 files changed, 0 insertions, 0 deletions