diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:56 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:53 +0200 |
| commit | d5938f29fea29581725426f203a74da746ca03e7 (patch) | |
| tree | 0caa694b1084f73004a8eacced417b1ef3073fcc /replay | |
| parent | b58c5c2dd29db0eae0bed800ac1a311e14007cec (diff) | |
| download | qemu-d5938f29fea29581725426f203a74da746ca03e7.zip qemu-d5938f29fea29581725426f203a74da746ca03e7.tar.gz qemu-d5938f29fea29581725426f203a74da746ca03e7.tar.bz2 | |
Clean up inclusion of sysemu/sysemu.h
In my "build everything" tree, changing sysemu/sysemu.h triggers a
recompile of some 5400 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h).
Almost a third of its inclusions are actually superfluous. Delete
them. Downgrade two more to qapi/qapi-types-run-state.h, and move one
from char/serial.h to char/serial.c.
hw/semihosting/config.c, monitor/monitor.c, qdev-monitor.c, and
stubs/semihost.c define variables declared in sysemu/sysemu.h without
including it. The compiler is cool with that, but include it anyway.
This doesn't reduce actual use much, as it's still included into
widely included headers. The next commit will tackle that.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-27-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Diffstat (limited to 'replay')
| -rw-r--r-- | replay/replay-audio.c | 1 | ||||
| -rw-r--r-- | replay/replay-char.c | 1 | ||||
| -rw-r--r-- | replay/replay-net.c | 1 | ||||
| -rw-r--r-- | replay/replay-snapshot.c | 1 |
4 files changed, 0 insertions, 4 deletions
diff --git a/replay/replay-audio.c b/replay/replay-audio.c index b113836..178094e 100644 --- a/replay/replay-audio.c +++ b/replay/replay-audio.c @@ -13,7 +13,6 @@ #include "qemu/error-report.h" #include "sysemu/replay.h" #include "replay-internal.h" -#include "sysemu/sysemu.h" #include "audio/audio.h" void replay_audio_out(int *played) diff --git a/replay/replay-char.c b/replay/replay-char.c index 736cc8c..dc00023 100644 --- a/replay/replay-char.c +++ b/replay/replay-char.c @@ -13,7 +13,6 @@ #include "qemu/error-report.h" #include "sysemu/replay.h" #include "replay-internal.h" -#include "sysemu/sysemu.h" #include "chardev/char.h" /* Char drivers that generate qemu_chr_be_write events diff --git a/replay/replay-net.c b/replay/replay-net.c index 80b7054..3b70f71 100644 --- a/replay/replay-net.c +++ b/replay/replay-net.c @@ -13,7 +13,6 @@ #include "qemu/error-report.h" #include "sysemu/replay.h" #include "replay-internal.h" -#include "sysemu/sysemu.h" #include "net/net.h" #include "net/filter.h" #include "qemu/iov.h" diff --git a/replay/replay-snapshot.c b/replay/replay-snapshot.c index 756f48b..5dd8680 100644 --- a/replay/replay-snapshot.c +++ b/replay/replay-snapshot.c @@ -13,7 +13,6 @@ #include "qapi/error.h" #include "sysemu/replay.h" #include "replay-internal.h" -#include "sysemu/sysemu.h" #include "monitor/monitor.h" #include "qapi/qmp/qstring.h" #include "qemu/error-report.h" |