diff options
author | Peter Maydell <peter.maydell@linaro.org> | 2022-01-07 17:07:58 +0000 |
---|---|---|
committer | Peter Maydell <peter.maydell@linaro.org> | 2022-01-07 17:07:58 +0000 |
commit | 62df780e3d4e918d984797f2d75b0cced157b757 (patch) | |
tree | e91232db69baace296df54d9ca09076544cf3f03 /qemu-io.c | |
parent | 6c1db43de4965b5274830bbd36298638a6dbb468 (diff) | |
download | qemu-62df780e3d4e918d984797f2d75b0cced157b757.zip qemu-62df780e3d4e918d984797f2d75b0cced157b757.tar.gz qemu-62df780e3d4e918d984797f2d75b0cced157b757.tar.bz2 |
hw/intc/arm_gicv3_its: Don't return early in extract_table_params() loop
In extract_table_params() we process each GITS_BASER<n> register. If
the register's Valid bit is not set, this means there is no
in-guest-memory table and so we should not try to interpret the other
fields in the register. This was incorrectly coded as a 'return'
rather than a 'break', so instead of looping round to process the
next GITS_BASER<n> we would stop entirely, treating any later tables
as being not valid also.
This has no real guest-visible effects because (since we don't have
GITS_TYPER.HCC != 0) the guest must in any case set up all the
GITS_BASER<n> to point to valid tables, so this only happens in an
odd misbehaving-guest corner case.
Fix the check to 'break', so that we leave the case statement and
loop back around to the next GITS_BASER<n>.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'qemu-io.c')
0 files changed, 0 insertions, 0 deletions