diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2016-07-27 01:15:04 +0400 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2016-07-29 00:33:47 +0300 |
| commit | a06db3ec720a570089b16125d3bca470e7bb34b8 (patch) | |
| tree | f133aefbd9667222b536cc6b1b50c357ff7c2bcf /qemu-io-cmds.c | |
| parent | f1a0365b686c2abdfde6303947f8893873b6b00b (diff) | |
| download | qemu-a06db3ec720a570089b16125d3bca470e7bb34b8.zip qemu-a06db3ec720a570089b16125d3bca470e7bb34b8.tar.gz qemu-a06db3ec720a570089b16125d3bca470e7bb34b8.tar.bz2 | |
vhost: fix calling vhost_dev_cleanup() after vhost_dev_init()
vhost_net_init() calls vhost_dev_init() and in case of failure, calls
vhost_dev_cleanup() directly. However, the structure is already
partially cleaned on error. Calling vhost_dev_cleanup() again will call
vhost_virtqueue_cleanup() on already clean queues, and causing potential
double-close. Instead, adjust dev->nvqs and simplify vhost_dev_init()
code to not call vhost_virtqueue_cleanup() but vhost_dev_cleanup()
instead.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'qemu-io-cmds.c')
0 files changed, 0 insertions, 0 deletions