diff options
author | Kevin Wolf <kwolf@redhat.com> | 2023-02-03 16:21:43 +0100 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2023-02-23 19:49:07 +0100 |
commit | 7ff9579e60a42e253c6bbbd7ba613f19cc007259 (patch) | |
tree | 32478e144a9e57f32d024c781815c31d2de8175d /qemu-img.c | |
parent | c2b8e315162bd5d5ab30c57bcc7bbb88b3ec4d54 (diff) | |
download | qemu-7ff9579e60a42e253c6bbbd7ba613f19cc007259.zip qemu-7ff9579e60a42e253c6bbbd7ba613f19cc007259.tar.gz qemu-7ff9579e60a42e253c6bbbd7ba613f19cc007259.tar.bz2 |
block: Mark bdrv_co_block_status() and callers GRAPH_RDLOCK
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_co_block_status() need to hold a reader lock for the graph.
For some places, we know that they will hold the lock, but we don't have
the GRAPH_RDLOCK annotations yet. In this case, add assume_graph_lock()
with a FIXME comment. These places will be removed once everything is
properly annotated.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230203152202.49054-5-kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'qemu-img.c')
-rw-r--r-- | qemu-img.c | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -1991,7 +1991,9 @@ static void coroutine_fn convert_co_do_copy(void *opaque) qemu_co_mutex_unlock(&s->lock); break; } - n = convert_iteration_sectors(s, s->sector_num); + WITH_GRAPH_RDLOCK_GUARD() { + n = convert_iteration_sectors(s, s->sector_num); + } if (n < 0) { qemu_co_mutex_unlock(&s->lock); s->ret = n; |