aboutsummaryrefslogtreecommitdiff
path: root/qapi
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2024-03-12 15:13:38 +0100
committerMarkus Armbruster <armbru@redhat.com>2024-04-24 09:50:58 +0200
commitc6f5d406e1ace1e3d7697e085024a3c7b93d6db5 (patch)
tree54fe10c9f3d3b2ac0fb8306b30373ab6ffd404a5 /qapi
parentf95b25c37e34d575346fb171b2f59c162bbefb38 (diff)
downloadqemu-c6f5d406e1ace1e3d7697e085024a3c7b93d6db5.zip
qemu-c6f5d406e1ace1e3d7697e085024a3c7b93d6db5.tar.gz
qemu-c6f5d406e1ace1e3d7697e085024a3c7b93d6db5.tar.bz2
qapi: Inline and remove QERR_INVALID_PARAMETER definition
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using: $ sed -i -e "s/QERR_INVALID_PARAMETER,/\"Invalid parameter '%s'\",/" \ $(git grep -lw QERR_INVALID_PARAMETER) Manually simplify qemu_opts_create(), and remove the macro definition in include/qapi/qmp/qerror.h. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-ID: <20240312141343.3168265-6-armbru@redhat.com>
Diffstat (limited to 'qapi')
-rw-r--r--qapi/opts-visitor.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 8f1efab..3d1a28b 100644
--- a/qapi/opts-visitor.c
+++ b/qapi/opts-visitor.c
@@ -184,7 +184,7 @@ opts_check_struct(Visitor *v, Error **errp)
const QemuOpt *first;
first = g_queue_peek_head(any);
- error_setg(errp, QERR_INVALID_PARAMETER, first->name);
+ error_setg(errp, "Invalid parameter '%s'", first->name);
return false;
}
return true;