diff options
| author | John Snow <jsnow@redhat.com> | 2022-02-25 15:59:41 -0500 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2022-03-07 14:36:41 -0500 |
| commit | 68a6cf3ffe3532c0655efbbf5910bd99a1b4a3fa (patch) | |
| tree | 4f7b984907354bf83aa59c25dd0a94f21b8a1d88 /python/tests | |
| parent | 0ba4e76b23fed77d09be7f56da783ab3f0b2d497 (diff) | |
| download | qemu-68a6cf3ffe3532c0655efbbf5910bd99a1b4a3fa.zip qemu-68a6cf3ffe3532c0655efbbf5910bd99a1b4a3fa.tar.gz qemu-68a6cf3ffe3532c0655efbbf5910bd99a1b4a3fa.tar.bz2 | |
python/aqmp: remove _new_session and _establish_connection
These two methods attempted to entirely envelop the logic of
establishing a connection to a peer start to finish. However, we need to
break apart the incoming connection step into more granular steps. We
will no longer be able to reasonably constrain the logic inside of these
helper functions.
So, remove them - with _session_guard(), they no longer serve a real
purpose.
Although the public API doesn't change, the internal API does. Now that
there are no intermediary methods between e.g. connect() and
_do_connect(), there's no hook where the runstate is set. As a result,
the test suite changes a little to cope with the new semantics of
_do_accept() and _do_connect().
Lastly, take some pieces of the now-deleted docstrings and move
them up to the public interface level. They were a little more detailed,
and it won't hurt to keep them.
Signed-off-by: John Snow <jsnow@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20220225205948.3693480-4-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'python/tests')
| -rw-r--r-- | python/tests/protocol.py | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/python/tests/protocol.py b/python/tests/protocol.py index 354d655..8dd26c4 100644 --- a/python/tests/protocol.py +++ b/python/tests/protocol.py @@ -42,11 +42,17 @@ class NullProtocol(AsyncProtocol[None]): await super()._establish_session() async def _do_accept(self, address, ssl=None): - if not self.fake_session: + if self.fake_session: + self._set_state(Runstate.CONNECTING) + await asyncio.sleep(0) + else: await super()._do_accept(address, ssl) async def _do_connect(self, address, ssl=None): - if not self.fake_session: + if self.fake_session: + self._set_state(Runstate.CONNECTING) + await asyncio.sleep(0) + else: await super()._do_connect(address, ssl) async def _do_recv(self) -> None: |