aboutsummaryrefslogtreecommitdiff
path: root/python/qemu
diff options
context:
space:
mode:
authorJohn Snow <jsnow@redhat.com>2021-06-29 17:43:11 -0400
committerJohn Snow <jsnow@redhat.com>2021-06-30 21:54:04 -0400
commit82e6517d9d0a1ce9fdc09919af26775a5127a5ec (patch)
tree863d5873c093172dfbadfb7e8f1fa1547d3f9aa9 /python/qemu
parent7f179082638efe920748b5243423bdcaed3d42ef (diff)
downloadqemu-82e6517d9d0a1ce9fdc09919af26775a5127a5ec.zip
qemu-82e6517d9d0a1ce9fdc09919af26775a5127a5ec.tar.gz
qemu-82e6517d9d0a1ce9fdc09919af26775a5127a5ec.tar.bz2
python: Remove global pylint suppressions
These suppressions only apply to a small handful of places. Instead of disabling them globally, disable them just in the cases where we need. The design of the machine class grew quite organically with tons of constructor and class instance variables -- there's little chance of meaningfully refactoring it in the near term, so just suppress the warnings for that class. Signed-off-by: John Snow <jsnow@redhat.com> Reviewed-by: Willian Rampazzo <willianr@redhat.com> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> Message-id: 20210629214323.1329806-4-jsnow@redhat.com Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'python/qemu')
-rw-r--r--python/qemu/machine/machine.py3
-rw-r--r--python/qemu/machine/qtest.py2
2 files changed, 5 insertions, 0 deletions
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index b624355..e3345df 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -84,6 +84,7 @@ class QEMUMachine:
...
# vm is guaranteed to be shut down here
"""
+ # pylint: disable=too-many-instance-attributes, too-many-public-methods
def __init__(self,
binary: str,
@@ -111,6 +112,8 @@ class QEMUMachine:
@param console_log: (optional) path to console log file
@note: Qemu process is not started until launch() is used.
'''
+ # pylint: disable=too-many-arguments
+
# Direct user configuration
self._binary = binary
diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py
index 9370068..d6d9c6a 100644
--- a/python/qemu/machine/qtest.py
+++ b/python/qemu/machine/qtest.py
@@ -116,6 +116,8 @@ class QEMUQtestMachine(QEMUMachine):
base_temp_dir: str = "/var/tmp",
socket_scm_helper: Optional[str] = None,
sock_dir: Optional[str] = None):
+ # pylint: disable=too-many-arguments
+
if name is None:
name = "qemu-%d" % os.getpid()
if sock_dir is None: