aboutsummaryrefslogtreecommitdiff
path: root/python/qemu
diff options
context:
space:
mode:
authorJohn Snow <jsnow@redhat.com>2021-05-27 17:16:47 -0400
committerJohn Snow <jsnow@redhat.com>2021-06-01 16:21:21 -0400
commit14b41797d5eb20fb9c6d0a1fe809e8422938f230 (patch)
treece1dbe2886bfe090cb89c65e4e4cc6c4649a9b04 /python/qemu
parent07b71233a7ea77c0ec3687c3a3451865b3b899d3 (diff)
downloadqemu-14b41797d5eb20fb9c6d0a1fe809e8422938f230.zip
qemu-14b41797d5eb20fb9c6d0a1fe809e8422938f230.tar.gz
qemu-14b41797d5eb20fb9c6d0a1fe809e8422938f230.tar.bz2
python/machine: use subprocess.run instead of subprocess.Popen
use run() instead of Popen() -- to assert to pylint that we are not forgetting to close a long-running program. Signed-off-by: John Snow <jsnow@redhat.com> Reviewed-by: Cleber Rosa <crosa@redhat.com> Tested-by: Cleber Rosa <crosa@redhat.com> Message-id: 20210527211715.394144-4-jsnow@redhat.com Message-id: 20210517184808.3562549-4-jsnow@redhat.com Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'python/qemu')
-rw-r--r--python/qemu/machine.py15
1 files changed, 9 insertions, 6 deletions
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index 5b87e9c..04e005f 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -223,13 +223,16 @@ class QEMUMachine:
assert fd is not None
fd_param.append(str(fd))
- proc = subprocess.Popen(
- fd_param, stdin=subprocess.DEVNULL, stdout=subprocess.PIPE,
- stderr=subprocess.STDOUT, close_fds=False
+ proc = subprocess.run(
+ fd_param,
+ stdin=subprocess.DEVNULL,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.STDOUT,
+ check=False,
+ close_fds=False,
)
- output = proc.communicate()[0]
- if output:
- LOG.debug(output)
+ if proc.stdout:
+ LOG.debug(proc.stdout)
return proc.returncode