aboutsummaryrefslogtreecommitdiff
path: root/pc-bios/bios-256k.bin
diff options
context:
space:
mode:
authorZhao Liu <zhao1.liu@intel.com>2023-10-23 17:46:22 +0800
committerMichael S. Tsirkin <mst@redhat.com>2023-11-07 03:39:11 -0500
commitdf210963a10e5ca884908addeb07aa081c5b7ad2 (patch)
treeb4c6e2cdb3a9235b4c637f98ed9e03630481002f /pc-bios/bios-256k.bin
parent6c7937ece909d3df0d2b4e94909f57388f5ed666 (diff)
downloadqemu-df210963a10e5ca884908addeb07aa081c5b7ad2.zip
qemu-df210963a10e5ca884908addeb07aa081c5b7ad2.tar.gz
qemu-df210963a10e5ca884908addeb07aa081c5b7ad2.tar.bz2
tests: bios-tables-test: Add test for smbios type4 count
This tests the commit d79a284a44bb7 ("hw/smbios: Fix smbios_smp_sockets calculation"). In smbios_get_tables() (hw/smbios/smbios.c), smbios type4 table is built for each socket, so the count of type4 tables should be equal to the number of sockets. Thus for the topology in this case, there're the following considerations: 1. The topology should include multiple sockets to ensure smbios could create type4 tables for each socket. 2. In addition to sockets, for the more general topology, we should also configure as many topology levels as possible (multiple dies, no module since x86 hasn't supported it), to ensure that smbios is able to exclude the effect of other topology levels to create the type4 tables only for sockets. 3. The original miscalculation bug also misused "smp.cpus", so it's necessary to configure "cpus" (presented threads for machine) and "maxcpus" (total threads for machine) as well to make sure that configuring unpluged CPUs in smp (cpus < maxcpus) does not affect the correctness of the count of type4 tables. Based on these considerations, select the topology as the follow: -smp cpus=100,maxcpus=120,sockets=5,dies=2,cores=4,threads=3 The expected count of type4 tables = sockets (5). Suggested-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: Zhao Liu <zhao1.liu@intel.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Message-Id: <20231023094635.1588282-4-zhao1.liu@linux.intel.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'pc-bios/bios-256k.bin')
0 files changed, 0 insertions, 0 deletions