diff options
author | Fiona Ebner <f.ebner@proxmox.com> | 2023-12-18 11:13:40 +0100 |
---|---|---|
committer | Daniel P. Berrangé <berrange@redhat.com> | 2024-02-09 12:47:58 +0000 |
commit | 03e471c41d8b1b6eb16c9714f387449f52fe5c1d (patch) | |
tree | 4f14dd51f82a8a3c985b8ab9f1826e6d031f30e4 /os-posix.c | |
parent | 52ed9f455ee0063958a1b18e54cab9a427fc422f (diff) | |
download | qemu-03e471c41d8b1b6eb16c9714f387449f52fe5c1d.zip qemu-03e471c41d8b1b6eb16c9714f387449f52fe5c1d.tar.gz qemu-03e471c41d8b1b6eb16c9714f387449f52fe5c1d.tar.bz2 |
qemu_init: increase NOFILE soft limit on POSIX
In many configurations, e.g. multiple vNICs with multiple queues or
with many Ceph OSDs, the default soft limit of 1024 is not enough.
QEMU is supposed to work fine with file descriptors >= 1024 and does
not use select() on POSIX. Bump the soft limit to the allowed hard
limit to avoid issues with the aforementioned configurations.
Of course the limit could be raised from the outside, but the man page
of systemd.exec states about 'LimitNOFILE=':
> Don't use.
> [...]
> Typically applications should increase their soft limit to the hard
> limit on their own, if they are OK with working with file
> descriptors above 1023,
If the soft limit is already the same as the hard limit, avoid the
superfluous setrlimit call. This can avoid a warning with a strict
seccomp filter blocking setrlimit if NOFILE was already raised before
executing QEMU.
Buglink: https://bugzilla.proxmox.com/show_bug.cgi?id=4507
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'os-posix.c')
-rw-r--r-- | os-posix.c | 22 |
1 files changed, 22 insertions, 0 deletions
@@ -24,6 +24,7 @@ */ #include "qemu/osdep.h" +#include <sys/resource.h> #include <sys/wait.h> #include <pwd.h> #include <grp.h> @@ -256,6 +257,27 @@ void os_daemonize(void) } } +void os_setup_limits(void) +{ + struct rlimit nofile; + + if (getrlimit(RLIMIT_NOFILE, &nofile) < 0) { + warn_report("unable to query NOFILE limit: %s", strerror(errno)); + return; + } + + if (nofile.rlim_cur == nofile.rlim_max) { + return; + } + + nofile.rlim_cur = nofile.rlim_max; + + if (setrlimit(RLIMIT_NOFILE, &nofile) < 0) { + warn_report("unable to set NOFILE limit: %s", strerror(errno)); + return; + } +} + void os_setup_post(void) { int fd = 0; |