diff options
| author | Steve Sistare <steven.sistare@oracle.com> | 2024-02-22 09:28:30 -0800 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2024-02-28 11:31:28 +0800 |
| commit | 9d9babf78d8f0a2f26b8dd5de3767bd4a4e2020e (patch) | |
| tree | 81614f1d26e880cb76cd8d2b4157e7ea1b52adb7 /net | |
| parent | 3e7757301cc93eaca47cad855630467804b1a2a4 (diff) | |
| download | qemu-9d9babf78d8f0a2f26b8dd5de3767bd4a4e2020e.zip qemu-9d9babf78d8f0a2f26b8dd5de3767bd4a4e2020e.tar.gz qemu-9d9babf78d8f0a2f26b8dd5de3767bd4a4e2020e.tar.bz2 | |
migration: MigrationEvent for notifiers
Passing MigrationState to notifiers is unsound because they could access
unstable migration state internals or even modify the state. Instead, pass
the minimal info needed in a new MigrationEvent struct, which could be
extended in the future if needed.
Suggested-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/1708622920-68779-5-git-send-email-steven.sistare@oracle.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/vhost-vdpa.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 1c00519..a29d18a 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -325,13 +325,13 @@ static void vhost_vdpa_net_log_global_enable(VhostVDPAState *s, bool enable) static int vdpa_net_migration_state_notifier(NotifierWithReturn *notifier, void *data, Error **errp) { - MigrationState *migration = data; + MigrationEvent *e = data; VhostVDPAState *s = container_of(notifier, VhostVDPAState, migration_state); - if (migration_in_setup(migration)) { + if (e->type == MIG_EVENT_PRECOPY_SETUP) { vhost_vdpa_net_log_global_enable(s, true); - } else if (migration_has_failed(migration)) { + } else if (e->type == MIG_EVENT_PRECOPY_FAILED) { vhost_vdpa_net_log_global_enable(s, false); } return 0; |