diff options
| author | Markus Armbruster <armbru@redhat.com> | 2023-01-24 13:19:21 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2023-02-04 07:56:54 +0100 |
| commit | 5ec92f2d92709964bd9247346097536c02394b3a (patch) | |
| tree | e411dfb7cf642cb2efa574aa4df7ddf96260b4bf /monitor | |
| parent | 52f50b1e9f8fd410d4293a211d549ec61b902728 (diff) | |
| download | qemu-5ec92f2d92709964bd9247346097536c02394b3a.zip qemu-5ec92f2d92709964bd9247346097536c02394b3a.tar.gz qemu-5ec92f2d92709964bd9247346097536c02394b3a.tar.bz2 | |
hmp: Rename help_cmd() to hmp_help_cmd(), move declaration to hmp.h
The next commit will move a caller of help_cmd() to a new file.
Including monitor/monitor-internal.h there just for help_cmd() feels
silly. Better to provide it in monitor/hmp.h suitably renamed.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230124121946.1139465-8-armbru@redhat.com>
Diffstat (limited to 'monitor')
| -rw-r--r-- | monitor/hmp.c | 2 | ||||
| -rw-r--r-- | monitor/misc.c | 8 | ||||
| -rw-r--r-- | monitor/monitor-internal.h | 1 |
3 files changed, 5 insertions, 6 deletions
diff --git a/monitor/hmp.c b/monitor/hmp.c index 1b04f01..2aa85d3 100644 --- a/monitor/hmp.c +++ b/monitor/hmp.c @@ -272,7 +272,7 @@ static void help_cmd_dump(Monitor *mon, const HMPCommand *cmds, } } -void help_cmd(Monitor *mon, const char *name) +void hmp_help_cmd(Monitor *mon, const char *name) { char *args[MAX_ARGS]; int nb_args = 0; diff --git a/monitor/misc.c b/monitor/misc.c index 9da5293..240d137 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -153,7 +153,7 @@ int hmp_compare_cmd(const char *name, const char *list) static void do_help_cmd(Monitor *mon, const QDict *qdict) { - help_cmd(mon, qdict_get_try_str(qdict, "name")); + hmp_help_cmd(mon, qdict_get_try_str(qdict, "name")); } static void hmp_trace_event(Monitor *mon, const QDict *qdict) @@ -195,14 +195,14 @@ static void hmp_trace_file(Monitor *mon, const QDict *qdict) } } else { monitor_printf(mon, "unexpected argument \"%s\"\n", op); - help_cmd(mon, "trace-file"); + hmp_help_cmd(mon, "trace-file"); } } #endif static void hmp_info_help(Monitor *mon, const QDict *qdict) { - help_cmd(mon, "info"); + hmp_help_cmd(mon, "info"); } static void monitor_init_qmp_commands(void) @@ -424,7 +424,7 @@ static void hmp_log(Monitor *mon, const QDict *qdict) } else { mask = qemu_str_to_log_mask(items); if (!mask) { - help_cmd(mon, "log"); + hmp_help_cmd(mon, "log"); return; } } diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h index a2cdbbf..53e3808 100644 --- a/monitor/monitor-internal.h +++ b/monitor/monitor-internal.h @@ -186,7 +186,6 @@ void monitor_data_destroy_qmp(MonitorQMP *mon); void coroutine_fn monitor_qmp_dispatcher_co(void *data); int get_monitor_def(Monitor *mon, int64_t *pval, const char *name); -void help_cmd(Monitor *mon, const char *name); void handle_hmp_command(MonitorHMP *mon, const char *cmdline); int hmp_compare_cmd(const char *name, const char *list); |