diff options
| author | Peter Xu <peterx@redhat.com> | 2022-10-11 17:55:47 -0400 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2022-12-15 10:30:37 +0100 |
| commit | ef5c3d13916f04176ed2d6d8405fb678e50b043f (patch) | |
| tree | e82892f15684201c5ac95752750f8f2f4515116a /migration | |
| parent | 20123ee1ded768a908d96b39b17ea281dfdb0ea6 (diff) | |
| download | qemu-ef5c3d13916f04176ed2d6d8405fb678e50b043f.zip qemu-ef5c3d13916f04176ed2d6d8405fb678e50b043f.tar.gz qemu-ef5c3d13916f04176ed2d6d8405fb678e50b043f.tar.bz2 | |
migration: Cleanup xbzrle zero page cache update logic
The major change is to replace "!save_page_use_compression()" with
"xbzrle_enabled" to make it clear.
Reasonings:
(1) When compression enabled, "!save_page_use_compression()" is exactly the
same as checking "xbzrle_enabled".
(2) When compression disabled, "!save_page_use_compression()" always return
true. We used to try calling the xbzrle code, but after this change we
won't, and we shouldn't need to.
Since at it, drop the xbzrle_enabled check in xbzrle_cache_zero_page()
because with this change it's not needed anymore.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/ram.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/migration/ram.c b/migration/ram.c index 00a2e30..7124ff5 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -741,10 +741,6 @@ void mig_throttle_counter_reset(void) */ static void xbzrle_cache_zero_page(RAMState *rs, ram_addr_t current_addr) { - if (!rs->xbzrle_enabled) { - return; - } - /* We don't care if this fails to allocate a new cache page * as long as it updated an old one */ cache_insert(XBZRLE.cache, current_addr, XBZRLE.zero_target_page, @@ -2301,7 +2297,7 @@ static int ram_save_target_page(RAMState *rs, PageSearchStatus *pss) /* Must let xbzrle know, otherwise a previous (now 0'd) cached * page would be stale */ - if (!save_page_use_compression(rs)) { + if (rs->xbzrle_enabled) { XBZRLE_cache_lock(); xbzrle_cache_zero_page(rs, block->offset + offset); XBZRLE_cache_unlock(); |