aboutsummaryrefslogtreecommitdiff
path: root/migration
diff options
context:
space:
mode:
authorLukas Straub <lukasstraub2@web.de>2021-07-04 18:14:44 +0200
committerJuan Quintela <quintela@trasno.org>2021-11-03 09:39:31 +0100
commite5fdf920964b65678798960d8b3a55453c2e9094 (patch)
tree97f21ab4672bcb6ea1516fa6519bb756e934bb9f /migration
parent2b9f6bf36c7483a07e45cc20cb0bb794769fb6d1 (diff)
downloadqemu-e5fdf920964b65678798960d8b3a55453c2e9094.zip
qemu-e5fdf920964b65678798960d8b3a55453c2e9094.tar.gz
qemu-e5fdf920964b65678798960d8b3a55453c2e9094.tar.bz2
colo: Don't dump colo cache if dump-guest-core=off
One might set dump-guest-core=off to make coredumps smaller and still allow to debug many qemu bugs. Extend this option to the colo cache. Signed-off-by: Lukas Straub <lukasstraub2@web.de> Reviewed-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration')
-rw-r--r--migration/ram.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/migration/ram.c b/migration/ram.c
index f5d39db..847af46 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -56,6 +56,8 @@
#include "multifd.h"
#include "sysemu/runstate.h"
+#include "hw/boards.h" /* for machine_dump_guest_core() */
+
#if defined(__linux__)
#include "qemu/userfaultfd.h"
#endif /* defined(__linux__) */
@@ -3542,6 +3544,10 @@ int colo_init_ram_cache(void)
}
return -errno;
}
+ if (!machine_dump_guest_core(current_machine)) {
+ qemu_madvise(block->colo_cache, block->used_length,
+ QEMU_MADV_DONTDUMP);
+ }
}
}