diff options
| author | Markus Armbruster <armbru@redhat.com> | 2023-09-28 15:20:14 +0200 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2023-10-11 11:17:04 +0200 |
| commit | 8dee156c1d60fd386bf19ac6bbccc04ef56a9f02 (patch) | |
| tree | ed69d2dcfd23513a5a2e4f408cbda566a4223c9f /migration | |
| parent | 01efb106373551e92efde579b16c1b8aa4ee9354 (diff) | |
| download | qemu-8dee156c1d60fd386bf19ac6bbccc04ef56a9f02.zip qemu-8dee156c1d60fd386bf19ac6bbccc04ef56a9f02.tar.gz qemu-8dee156c1d60fd386bf19ac6bbccc04ef56a9f02.tar.bz2 | |
migration/rdma: Don't report received completion events as error
When qemu_rdma_wait_comp_channel() receives an event from the
completion channel, it reports an error "receive cm event while wait
comp channel,cm event is T", where T is the numeric event type.
However, the function fails only when T is a disconnect or device
removal. Events other than these two are not actually an error, and
reporting them as an error is wrong. If we need to report them to the
user, we should use something else, and what to use depends on why we
need to report them to the user.
For now, report this error only when the function actually fails.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230928132019.2544702-49-armbru@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/rdma.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/migration/rdma.c b/migration/rdma.c index 6a8ff8f..b5bb471 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -1582,11 +1582,11 @@ static int qemu_rdma_wait_comp_channel(RDMAContext *rdma, return -1; } - error_report("receive cm event while wait comp channel," - "cm event is %d", cm_event->event); if (cm_event->event == RDMA_CM_EVENT_DISCONNECTED || cm_event->event == RDMA_CM_EVENT_DEVICE_REMOVAL) { rdma_ack_cm_event(cm_event); + error_report("receive cm event while wait comp channel," + "cm event is %d", cm_event->event); return -1; } rdma_ack_cm_event(cm_event); |