diff options
| author | Hyman Huang(黄勇) <yong.huang@smartx.com> | 2023-06-15 21:29:44 +0800 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2023-07-26 10:55:56 +0200 |
| commit | 310ad5625e107568a0204ec1e1623e267fad3a9a (patch) | |
| tree | 537e8ba01db9133068a4667f3004b96b57f9f711 /migration | |
| parent | bb9993c6725ac13098058f873efb06880ce46c32 (diff) | |
| download | qemu-310ad5625e107568a0204ec1e1623e267fad3a9a.zip qemu-310ad5625e107568a0204ec1e1623e267fad3a9a.tar.gz qemu-310ad5625e107568a0204ec1e1623e267fad3a9a.tar.bz2 | |
migration: Put the detection logic before auto-converge checking
This commit is prepared for the implementation of dirty-limit
convergence algo.
The detection logic of throttling condition can apply to both
auto-converge and dirty-limit algo, putting it's position
before the checking logic for auto-converge feature.
Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-ID: <168733225273.5845.15871826788879741674-6@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/ram.c | 21 |
1 files changed, 11 insertions, 10 deletions
diff --git a/migration/ram.c b/migration/ram.c index f31de47..1d9300f 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -999,17 +999,18 @@ static void migration_trigger_throttle(RAMState *rs) return; } - if (migrate_auto_converge()) { - /* The following detection logic can be refined later. For now: - Check to see if the ratio between dirtied bytes and the approx. - amount of bytes that just got transferred since the last time - we were in this routine reaches the threshold. If that happens - twice, start or increase throttling. */ - - if ((bytes_dirty_period > bytes_dirty_threshold) && - (++rs->dirty_rate_high_cnt >= 2)) { + /* + * The following detection logic can be refined later. For now: + * Check to see if the ratio between dirtied bytes and the approx. + * amount of bytes that just got transferred since the last time + * we were in this routine reaches the threshold. If that happens + * twice, start or increase throttling. + */ + if ((bytes_dirty_period > bytes_dirty_threshold) && + (++rs->dirty_rate_high_cnt >= 2)) { + rs->dirty_rate_high_cnt = 0; + if (migrate_auto_converge()) { trace_migration_throttle(); - rs->dirty_rate_high_cnt = 0; mig_throttle_guest_down(bytes_dirty_period, bytes_dirty_threshold); } |