diff options
| author | William Roche <william.roche@oracle.com> | 2024-01-30 19:06:40 +0000 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2024-02-05 14:41:58 +0800 |
| commit | 06152b89db64bc5ccec1e54576706ba891654df9 (patch) | |
| tree | df0fe21a342e770e23e964332630f18aa0a0221a /migration | |
| parent | 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440 (diff) | |
| download | qemu-06152b89db64bc5ccec1e54576706ba891654df9.zip qemu-06152b89db64bc5ccec1e54576706ba891654df9.tar.gz qemu-06152b89db64bc5ccec1e54576706ba891654df9.tar.bz2 | |
migration: prevent migration when VM has poisoned memory
A memory page poisoned from the hypervisor level is no longer readable.
The migration of a VM will crash Qemu when it tries to read the
memory address space and stumbles on the poisoned page with a similar
stack trace:
Program terminated with signal SIGBUS, Bus error.
#0 _mm256_loadu_si256
#1 buffer_zero_avx2
#2 select_accel_fn
#3 buffer_is_zero
#4 save_zero_page
#5 ram_save_target_page_legacy
#6 ram_save_host_page
#7 ram_find_and_save_block
#8 ram_save_iterate
#9 qemu_savevm_state_iterate
#10 migration_iteration_run
#11 migration_thread
#12 qemu_thread_start
To avoid this VM crash during the migration, prevent the migration
when a known hardware poison exists on the VM.
Signed-off-by: William Roche <william.roche@oracle.com>
Link: https://lore.kernel.org/r/20240130190640.139364-2-william.roche@oracle.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/migration.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/migration/migration.c b/migration/migration.c index d5f705c..b574e66 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -67,6 +67,7 @@ #include "options.h" #include "sysemu/dirtylimit.h" #include "qemu/sockets.h" +#include "sysemu/kvm.h" static NotifierList migration_state_notifiers = NOTIFIER_LIST_INITIALIZER(migration_state_notifiers); @@ -1906,6 +1907,12 @@ static bool migrate_prepare(MigrationState *s, bool blk, bool blk_inc, return false; } + if (kvm_hwpoisoned_mem()) { + error_setg(errp, "Can't migrate this vm with hardware poisoned memory, " + "please reboot the vm and try again"); + return false; + } + if (migration_is_blocked(errp)) { return false; } |