diff options
| author | Leonardo Bras <leobras@redhat.com> | 2023-02-10 03:36:29 -0300 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2023-02-13 03:45:28 +0100 |
| commit | d926f3bb2a84fdb746678629279a143f568c3c86 (patch) | |
| tree | b9b6b12d7832df5b852055e663eb5ba79c8641cd /migration | |
| parent | e5bac1f525472d6042a4cdba31dda5825cde0086 (diff) | |
| download | qemu-d926f3bb2a84fdb746678629279a143f568c3c86.zip qemu-d926f3bb2a84fdb746678629279a143f568c3c86.tar.gz qemu-d926f3bb2a84fdb746678629279a143f568c3c86.tar.bz2 | |
migration/multifd: Remove unnecessary assignment on multifd_load_cleanup()
Before assigning "p->quit = true" for every multifd channel,
multifd_load_cleanup() will call multifd_recv_terminate_threads() which
already does the same assignment, while protected by a mutex.
So there is no point doing the same assignment again.
Fixes: b5eea99ec2 ("migration: Add yank feature")
Reported-by: Li Xiaohui <xiaohli@redhat.com>
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/multifd.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/migration/multifd.c b/migration/multifd.c index cac8496..3dd569d 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -1025,7 +1025,6 @@ void multifd_load_cleanup(void) MultiFDRecvParams *p = &multifd_recv_state->params[i]; if (p->running) { - p->quit = true; /* * multifd_recv_thread may hung at MULTIFD_FLAG_SYNC handle code, * however try to wakeup it without harm in cleanup phase. |