From d926f3bb2a84fdb746678629279a143f568c3c86 Mon Sep 17 00:00:00 2001 From: Leonardo Bras Date: Fri, 10 Feb 2023 03:36:29 -0300 Subject: migration/multifd: Remove unnecessary assignment on multifd_load_cleanup() Before assigning "p->quit = true" for every multifd channel, multifd_load_cleanup() will call multifd_recv_terminate_threads() which already does the same assignment, while protected by a mutex. So there is no point doing the same assignment again. Fixes: b5eea99ec2 ("migration: Add yank feature") Reported-by: Li Xiaohui Signed-off-by: Leonardo Bras Reviewed-by: Juan Quintela Reviewed-by: Peter Xu Signed-off-by: Juan Quintela --- migration/multifd.c | 1 - 1 file changed, 1 deletion(-) (limited to 'migration') diff --git a/migration/multifd.c b/migration/multifd.c index cac8496..3dd569d 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -1025,7 +1025,6 @@ void multifd_load_cleanup(void) MultiFDRecvParams *p = &multifd_recv_state->params[i]; if (p->running) { - p->quit = true; /* * multifd_recv_thread may hung at MULTIFD_FLAG_SYNC handle code, * however try to wakeup it without harm in cleanup phase. -- cgit v1.1