diff options
| author | Wei Yang <richardw.yang@linux.intel.com> | 2019-07-18 14:42:57 +0800 |
|---|---|---|
| committer | Dr. David Alan Gilbert <dgilbert@redhat.com> | 2019-08-14 17:33:14 +0100 |
| commit | 4695ce3fdcb636384eac743cee9a1b6375ad0ccb (patch) | |
| tree | b619d60426252b3e83282c84217971cb2d5c199c /migration/savevm.c | |
| parent | 5d0980a459774a52e3f3729cee0a2562d11026d2 (diff) | |
| download | qemu-4695ce3fdcb636384eac743cee9a1b6375ad0ccb.zip qemu-4695ce3fdcb636384eac743cee9a1b6375ad0ccb.tar.gz qemu-4695ce3fdcb636384eac743cee9a1b6375ad0ccb.tar.bz2 | |
migration: equation is more proper than and to check LOADVM_QUIT
LOADVM_QUIT allows a command to quit all layers of nested loadvm loops,
while current return value check is not that proper even it works now.
Current return value check "ret & LOADVM_QUIT" would return true if
bit[0] is 1. This would be true when ret is -1 which is used to indicate
an error of handling a command.
Since there is only one place return LOADVM_QUIT and no other
combination of return value, use "ret == LOADVM_QUIT" would be more
proper.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Message-Id: <20190718064257.29218-1-richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'migration/savevm.c')
| -rw-r--r-- | migration/savevm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/migration/savevm.c b/migration/savevm.c index eed5e55..4127682 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2437,7 +2437,7 @@ retry: case QEMU_VM_COMMAND: ret = loadvm_process_command(f); trace_qemu_loadvm_state_section_command(ret); - if ((ret < 0) || (ret & LOADVM_QUIT)) { + if ((ret < 0) || (ret == LOADVM_QUIT)) { goto out; } break; |