diff options
author | Markus Armbruster <armbru@redhat.com> | 2023-09-28 15:20:04 +0200 |
---|---|---|
committer | Juan Quintela <quintela@redhat.com> | 2023-10-11 11:17:04 +0200 |
commit | de1aa35f8dbb9666360648148e57ceacb1bf8b5b (patch) | |
tree | 47eca8ef80314dd1e29658eccd2b9feeb0b791b6 /migration/fd.h | |
parent | 3765ec1f432065e451fe86c54b93fc19a49f0cf4 (diff) | |
download | qemu-de1aa35f8dbb9666360648148e57ceacb1bf8b5b.zip qemu-de1aa35f8dbb9666360648148e57ceacb1bf8b5b.tar.gz qemu-de1aa35f8dbb9666360648148e57ceacb1bf8b5b.tar.bz2 |
migration/rdma: Convert qemu_rdma_reg_whole_ram_blocks() to Error
Functions that use an Error **errp parameter to return errors should
not also report them to the user, because reporting is the caller's
job. When the caller does, the error is reported twice. When it
doesn't (because it recovered from the error), there is no error to
report, i.e. the report is bogus.
qemu_rdma_exchange_send() violates this principle: it calls
error_report() via callback qemu_rdma_reg_whole_ram_blocks(). I
elected not to investigate how callers handle the error, i.e. precise
impact is not known.
Clean this up by converting the callback to Error.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230928132019.2544702-39-armbru@redhat.com>
Diffstat (limited to 'migration/fd.h')
0 files changed, 0 insertions, 0 deletions