diff options
author | Daniel P. Berrangé <berrange@redhat.com> | 2023-12-07 13:45:01 +0000 |
---|---|---|
committer | Daniel P. Berrangé <berrange@redhat.com> | 2024-02-09 12:48:02 +0000 |
commit | 0e74eb86eaf3ef57e9f9741cb668784c96e654ff (patch) | |
tree | 896e77a63f4d28e7cec532702280855cb4eb6257 /linux-user | |
parent | 03e471c41d8b1b6eb16c9714f387449f52fe5c1d (diff) | |
download | qemu-0e74eb86eaf3ef57e9f9741cb668784c96e654ff.zip qemu-0e74eb86eaf3ef57e9f9741cb668784c96e654ff.tar.gz qemu-0e74eb86eaf3ef57e9f9741cb668784c96e654ff.tar.bz2 |
ui: drop VNC feature _MASK constants
Each VNC feature enum entry has a corresponding _MASK constant
which is the bit-shifted value. It is very easy for contributors
to accidentally use the _MASK constant, instead of the non-_MASK
constant, or the reverse. No compiler warning is possible and
it'll just silently do the wrong thing at runtime.
By introducing the vnc_set_feature helper method, we can drop
all the _MASK constants and thus prevent any future accidents.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'linux-user')
0 files changed, 0 insertions, 0 deletions