diff options
| author | Richard Henderson <richard.henderson@linaro.org> | 2022-04-21 08:16:35 -0700 |
|---|---|---|
| committer | Richard Henderson <richard.henderson@linaro.org> | 2022-04-26 08:16:40 -0700 |
| commit | b3a219b70e269b3d22d7f65a895b2af9771a5544 (patch) | |
| tree | 67deda48e1cd0be8cc2fe9328977404336448b6b /linux-user/nios2 | |
| parent | 66254caa428d2cf4962c60c2f04959ac32cbf8b3 (diff) | |
| download | qemu-b3a219b70e269b3d22d7f65a895b2af9771a5544.zip qemu-b3a219b70e269b3d22d7f65a895b2af9771a5544.tar.gz qemu-b3a219b70e269b3d22d7f65a895b2af9771a5544.tar.bz2 | |
linux-user/nios2: Adjust error return
Follow the kernel assembly, which considers all negative
return values to be errors.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220421151735.31996-5-richard.henderson@linaro.org>
Diffstat (limited to 'linux-user/nios2')
| -rw-r--r-- | linux-user/nios2/cpu_loop.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index 91737c5..63afba5 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -55,9 +55,14 @@ void cpu_loop(CPUNios2State *env) env->regs[7], env->regs[8], env->regs[9], 0, 0); + /* + * See the code after translate_rc_and_ret: all negative + * values are errors (aided by userspace restricted to 2G), + * errno is returned positive in r2, and error indication + * is a boolean in r7. + */ env->regs[2] = abs(ret); - /* Return value is 0..4096 */ - env->regs[7] = ret > 0xfffff000u; + env->regs[7] = ret < 0; break; case 1: |