aboutsummaryrefslogtreecommitdiff
path: root/linux-user/main.c
diff options
context:
space:
mode:
authorChen Gang S <gang.chen@sunrus.com.cn>2015-01-25 19:03:29 +0800
committerRiku Voipio <riku.voipio@linaro.org>2015-03-22 15:16:55 +0200
commit92bed463d12ab9e1e34cdd44673ab9c4315ad1d2 (patch)
tree8272e1c19d73fa15e422217a0e1a841a75ded70a /linux-user/main.c
parent3c6c9fe034c0c07b77f272e4a53d7735220a16a4 (diff)
downloadqemu-92bed463d12ab9e1e34cdd44673ab9c4315ad1d2.zip
qemu-92bed463d12ab9e1e34cdd44673ab9c4315ad1d2.tar.gz
qemu-92bed463d12ab9e1e34cdd44673ab9c4315ad1d2.tar.bz2
linux-user/main.c: Remove redundant end_exclusive() in arm_kernel_cmpxchg64_helper()
start/end_exclusive() need be pairs, except the start_exclusive() in stop_all_tasks() which is only used by force_sig(), which will be abort. So at present, start_exclusive() in stop_all_task() need not be paired. queue_signal() may call force_sig(), or return after kill pid (or queue signal). If could return from queue_signal(), stop_all_task() would not be called in time, the next end_exclusive() would be issue. So in arm_kernel_cmpxchg64_helper() for ARM, need remove end_exclusive() after queue_signal(). The related commit: "97cc756 linux-user: Implement new ARM 64 bit cmpxchg kernel helper". Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Diffstat (limited to 'linux-user/main.c')
-rw-r--r--linux-user/main.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/linux-user/main.c b/linux-user/main.c
index 6e446de..31eb60f 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -525,8 +525,6 @@ segv:
info.si_code = TARGET_SEGV_MAPERR;
info._sifields._sigfault._addr = env->exception.vaddress;
queue_signal(env, info.si_signo, &info);
-
- end_exclusive();
}
/* Handle a jump to the kernel code page. */