diff options
author | Eduardo Habkost <ehabkost@redhat.com> | 2015-08-07 16:15:31 -0300 |
---|---|---|
committer | Michael S. Tsirkin <mst@redhat.com> | 2015-08-13 14:08:25 +0300 |
commit | e33d22fab3ad64bedc1c9addb0a0fa437995c12a (patch) | |
tree | 01afe4144118e2761e51ee7aea96a2dd54d6c7cc /include | |
parent | 27fa7479801ac23609110535a997b2e3ed6eb867 (diff) | |
download | qemu-e33d22fab3ad64bedc1c9addb0a0fa437995c12a.zip qemu-e33d22fab3ad64bedc1c9addb0a0fa437995c12a.tar.gz qemu-e33d22fab3ad64bedc1c9addb0a0fa437995c12a.tar.bz2 |
piix: Document coreboot-specific RAM size config register
The existing i440fx initialization code sets a PCI config register that
isn't documented anywhere in the Intel 440FX datasheet. Register 0x57 is
DRAMC (DRAM Control) and has nothing to do with the RAM size.
This was implemented in commit ec5f92ce6ac8ec09056be77e03c941be188648fa
because old coreboot code tried to read registers 0x5a-0x5f,0x56,0x57 to
get the RAM size from QEMU, but I couldn't find out why coreboot did
that. I assume it was a mistake, and the original code was supposed to
be reading the DRB[0-7] registers (offsets 0x60-0x67).
Document that coreboot-specific register offset in a macro and a
comment, for future reference.
Cc: Ed Swierk <eswierk@skyportsystems.com>
Cc: Richard Smith <smithbone@gmail.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions