diff options
| author | Igor Mammedov <imammedo@redhat.com> | 2024-03-14 16:22:49 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2024-03-18 08:42:45 -0400 |
| commit | 9cd7fd69cfad9180e22b9adb728fc7b596b4bc1e (patch) | |
| tree | 114f5154209f52b80739ef73961f9d6ecf703665 /include | |
| parent | cba59fe38a2bc2b1888892539d0c4688e07aa356 (diff) | |
| download | qemu-9cd7fd69cfad9180e22b9adb728fc7b596b4bc1e.zip qemu-9cd7fd69cfad9180e22b9adb728fc7b596b4bc1e.tar.gz qemu-9cd7fd69cfad9180e22b9adb728fc7b596b4bc1e.tar.bz2 | |
smbios: don't check type4 structures in legacy mode
legacy mode doesn't support structures of type 2 and more,
and CLI has a check for '-smbios type' option, however it's
still possible to sneak in type4 as a blob with '-smbios file'
option. However doing the later makes SMBIOS tables broken
since SeaBIOS doesn't expect that.
Rather than trying to add support for type4 to legacy code
(both QEMU and SeaBIOS), simplify smbios_get_table_legacy()
by dropping not relevant check in legacy code and error out
on type4 blob.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240314152302.2324164-9-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/hw/firmware/smbios.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/hw/firmware/smbios.h b/include/hw/firmware/smbios.h index 7b42e7b..0f0dca8 100644 --- a/include/hw/firmware/smbios.h +++ b/include/hw/firmware/smbios.h @@ -313,7 +313,7 @@ void smbios_set_defaults(const char *manufacturer, const char *product, const char *version, bool uuid_encoded, SmbiosEntryPointType ep_type); void smbios_set_default_processor_family(uint16_t processor_family); -uint8_t *smbios_get_table_legacy(uint32_t expected_t4_count, size_t *length); +uint8_t *smbios_get_table_legacy(size_t *length); void smbios_get_tables(MachineState *ms, const struct smbios_phys_mem_area *mem_array, const unsigned int mem_array_size, |