diff options
| author | Manos Pitsidianakis <manos.pitsidianakis@linaro.org> | 2024-01-30 09:30:32 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2024-01-30 16:19:00 -0500 |
| commit | 954b33daee83fe79293fd81c2f7371db48e7d6bd (patch) | |
| tree | c1d2e7cefc594f784175d9f30ca4556de542580d /include | |
| parent | 956ef499902b09aa8a3e70791455ccf45645032d (diff) | |
| download | qemu-954b33daee83fe79293fd81c2f7371db48e7d6bd.zip qemu-954b33daee83fe79293fd81c2f7371db48e7d6bd.tar.gz qemu-954b33daee83fe79293fd81c2f7371db48e7d6bd.tar.bz2 | |
hw/block/block.c: improve confusing blk_check_size_and_read_all() error
In cases where a device tries to read more bytes than the block device
contains, the error is vague: "device requires X bytes, block backend
provides Y bytes".
This patch changes the errors of this function to include the block
backend name, the device id and device type name where appropriate.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-id: 7260eadff22c08457740117c1bb7bd2b4353acb9.1706598705.git.manos.pitsidianakis@linaro.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/hw/block/block.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/hw/block/block.h b/include/hw/block/block.h index 15fff664..de3946a 100644 --- a/include/hw/block/block.h +++ b/include/hw/block/block.h @@ -88,8 +88,8 @@ static inline unsigned int get_physical_block_exp(BlockConf *conf) /* Backend access helpers */ -bool blk_check_size_and_read_all(BlockBackend *blk, void *buf, hwaddr size, - Error **errp); +bool blk_check_size_and_read_all(BlockBackend *blk, DeviceState *dev, + void *buf, hwaddr size, Error **errp); /* Configuration helpers */ |