diff options
| author | Alejandro Zeise <alejandro.zeise@seagate.com> | 2024-08-07 19:51:22 +0000 |
|---|---|---|
| committer | Cédric Le Goater <clg@redhat.com> | 2024-10-24 07:57:47 +0200 |
| commit | 4c1d0af4a28d15d04a9bd522a5c3976eda9f999e (patch) | |
| tree | 847c88040cccf0680b2e2d4494948215b8c5f866 /include | |
| parent | 34fdd734c5da7de39c09f3d8793042292f95dacc (diff) | |
| download | qemu-4c1d0af4a28d15d04a9bd522a5c3976eda9f999e.zip qemu-4c1d0af4a28d15d04a9bd522a5c3976eda9f999e.tar.gz qemu-4c1d0af4a28d15d04a9bd522a5c3976eda9f999e.tar.bz2 | |
hw/misc/aspeed_hace: Fix SG Accumulative hashing
Make the Aspeed HACE module use the new qcrypto accumulative hashing functions
when in scatter-gather accumulative mode. A hash context will maintain a
"running-hash" as each scatter-gather chunk is received.
Previously each scatter-gather "chunk" was cached
so the hash could be computed once the final chunk was received.
However, the cache was a shallow copy, so once the guest overwrote the
memory provided to HACE the final hash would not be correct.
Possibly related to: https://gitlab.com/qemu-project/qemu/-/issues/1121
Buglink: https://github.com/openbmc/qemu/issues/36
Signed-off-by: Alejandro Zeise <alejandro.zeise@seagate.com>
[ clg: - Checkpatch fixes
- Reworked qcrypto_hash*() error reports in do_hash_operation() ]
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Reviewed-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Diffstat (limited to 'include')
| -rw-r--r-- | include/hw/misc/aspeed_hace.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/include/hw/misc/aspeed_hace.h b/include/hw/misc/aspeed_hace.h index ecb1b67..4af9919 100644 --- a/include/hw/misc/aspeed_hace.h +++ b/include/hw/misc/aspeed_hace.h @@ -1,6 +1,7 @@ /* * ASPEED Hash and Crypto Engine * + * Copyright (c) 2024 Seagate Technology LLC and/or its Affiliates * Copyright (C) 2021 IBM Corp. * * SPDX-License-Identifier: GPL-2.0-or-later @@ -10,6 +11,7 @@ #define ASPEED_HACE_H #include "hw/sysbus.h" +#include "crypto/hash.h" #define TYPE_ASPEED_HACE "aspeed.hace" #define TYPE_ASPEED_AST2400_HACE TYPE_ASPEED_HACE "-ast2400" @@ -35,6 +37,8 @@ struct AspeedHACEState { MemoryRegion *dram_mr; AddressSpace dram_as; + + QCryptoHash *hash_ctx; }; |