diff options
| author | Corey Minyard <cminyard@mvista.com> | 2018-11-14 11:50:50 -0600 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2019-02-27 21:06:08 -0600 |
| commit | 2ac4c5f4d2415116d3f417a32311d437791dcfce (patch) | |
| tree | 5abf8e22939c5c1c030643ffe2fcdfe7bb16344c /include | |
| parent | 93198b6cad8af03996373584284a1673ad6000cb (diff) | |
| download | qemu-2ac4c5f4d2415116d3f417a32311d437791dcfce.zip qemu-2ac4c5f4d2415116d3f417a32311d437791dcfce.tar.gz qemu-2ac4c5f4d2415116d3f417a32311d437791dcfce.tar.bz2 | |
i2c: have I2C receive operation return uint8_t
It is never supposed to fail and cannot return an error, so just
have it return the proper type. Have it return 0xff on nothing
available, since that's what would happen on a real bus.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/hw/i2c/i2c.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h index cf4c45a..8e236f7 100644 --- a/include/hw/i2c/i2c.h +++ b/include/hw/i2c/i2c.h @@ -33,10 +33,9 @@ typedef struct I2CSlaveClass { /* * Slave to master. This cannot fail, the device should always - * return something here. Negative values probably result in 0xff - * and a possible log from the driver, and shouldn't be used. + * return something here. */ - int (*recv)(I2CSlave *s); + uint8_t (*recv)(I2CSlave *s); /* * Notify the slave of a bus state change. For start event, @@ -78,7 +77,7 @@ void i2c_end_transfer(I2CBus *bus); void i2c_nack(I2CBus *bus); int i2c_send_recv(I2CBus *bus, uint8_t *data, bool send); int i2c_send(I2CBus *bus, uint8_t data); -int i2c_recv(I2CBus *bus); +uint8_t i2c_recv(I2CBus *bus); DeviceState *i2c_create_slave(I2CBus *bus, const char *name, uint8_t addr); |