aboutsummaryrefslogtreecommitdiff
path: root/include/ui/egl-helpers.h
diff options
context:
space:
mode:
authorGerd Hoffmann <kraxel@redhat.com>2019-09-09 09:39:11 +0200
committerGerd Hoffmann <kraxel@redhat.com>2019-09-17 13:42:02 +0200
commitd2329237af197429492ec27d22a4ba4f121dbc10 (patch)
treea8bfaa3bb76ecc3f4d96faff146eab22be92e973 /include/ui/egl-helpers.h
parent89ea03a7dc83ca36b670ba7f787802791fcb04b1 (diff)
downloadqemu-d2329237af197429492ec27d22a4ba4f121dbc10.zip
qemu-d2329237af197429492ec27d22a4ba4f121dbc10.tar.gz
qemu-d2329237af197429492ec27d22a4ba4f121dbc10.tar.bz2
ui/egl: fix framebuffer reads
Fix egl_fb_read() to use the (destination) surface size instead of the (source) framebuffer source for glReadPixels. Pass the DisplaySurface instead of the pixeldata pointer to egl_fb_read() to make this possible. With that in place framebuffer reads work fine even if the surface and framebuffer sizes don't match, so we can remove the guest-triggerable asserts in egl_scanout_flush(). Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1749659 Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-id: 20190909073911.24787-1-kraxel@redhat.com
Diffstat (limited to 'include/ui/egl-helpers.h')
-rw-r--r--include/ui/egl-helpers.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h
index dad19e9..94a4b3e 100644
--- a/include/ui/egl-helpers.h
+++ b/include/ui/egl-helpers.h
@@ -25,7 +25,7 @@ void egl_fb_setup_for_tex(egl_fb *fb, int width, int height,
GLuint texture, bool delete);
void egl_fb_setup_new_tex(egl_fb *fb, int width, int height);
void egl_fb_blit(egl_fb *dst, egl_fb *src, bool flip);
-void egl_fb_read(void *dst, egl_fb *src);
+void egl_fb_read(DisplaySurface *dst, egl_fb *src);
void egl_texture_blit(QemuGLShader *gls, egl_fb *dst, egl_fb *src, bool flip);
void egl_texture_blend(QemuGLShader *gls, egl_fb *dst, egl_fb *src, bool flip,