diff options
| author | Hanna Czenczek <hreitz@redhat.com> | 2023-04-11 19:34:17 +0200 |
|---|---|---|
| committer | Hanna Czenczek <hreitz@redhat.com> | 2023-06-05 13:11:24 +0200 |
| commit | cc63f6f6fa1aaa4b6405dd69432c693e9c8d18ca (patch) | |
| tree | e3528fd018b77cc34d60cf0cb28b7914c54adc61 /include/qemu | |
| parent | 18743311b829cafc1737a5f20bc3248d5f91ee2a (diff) | |
| download | qemu-cc63f6f6fa1aaa4b6405dd69432c693e9c8d18ca.zip qemu-cc63f6f6fa1aaa4b6405dd69432c693e9c8d18ca.tar.gz qemu-cc63f6f6fa1aaa4b6405dd69432c693e9c8d18ca.tar.bz2 | |
util/iov: Remove qemu_iovec_init_extended()
bdrv_pad_request() was the main user of qemu_iovec_init_extended().
HEAD^ has removed that use, so we can remove qemu_iovec_init_extended()
now.
The only remaining user is qemu_iovec_init_slice(), which can easily
inline the small part it really needs.
Note that qemu_iovec_init_extended() offered a memcpy() optimization to
initialize the new I/O vector. qemu_iovec_concat_iov(), which is used
to replace its functionality, does not, but calls qemu_iovec_add() for
every single element. If we decide this optimization was important, we
will need to re-implement it in qemu_iovec_concat_iov(), which might
also benefit its pre-existing users.
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-4-hreitz@redhat.com>
Diffstat (limited to 'include/qemu')
| -rw-r--r-- | include/qemu/iov.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/include/qemu/iov.h b/include/qemu/iov.h index 46fadfb..63a1c01 100644 --- a/include/qemu/iov.h +++ b/include/qemu/iov.h @@ -222,11 +222,6 @@ static inline void *qemu_iovec_buf(QEMUIOVector *qiov) void qemu_iovec_init(QEMUIOVector *qiov, int alloc_hint); void qemu_iovec_init_external(QEMUIOVector *qiov, struct iovec *iov, int niov); -int qemu_iovec_init_extended( - QEMUIOVector *qiov, - void *head_buf, size_t head_len, - QEMUIOVector *mid_qiov, size_t mid_offset, size_t mid_len, - void *tail_buf, size_t tail_len); void qemu_iovec_init_slice(QEMUIOVector *qiov, QEMUIOVector *source, size_t offset, size_t len); struct iovec *qemu_iovec_slice(QEMUIOVector *qiov, |