diff options
| author | Markus Armbruster <armbru@redhat.com> | 2018-08-06 08:53:31 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2018-08-16 08:42:06 +0200 |
| commit | 2d36e843042d2ef47f3bfc47a1a83401fdb07b84 (patch) | |
| tree | cf0c271134caf76933cb959864404f46e6695341 /include/qapi | |
| parent | eac78bd430f357b9d935afaa09355c6fc6a13e3d (diff) | |
| download | qemu-2d36e843042d2ef47f3bfc47a1a83401fdb07b84.zip qemu-2d36e843042d2ef47f3bfc47a1a83401fdb07b84.tar.gz qemu-2d36e843042d2ef47f3bfc47a1a83401fdb07b84.tar.bz2 | |
qobject: qobject_from_jsonv() is dangerous, hide it away
qobject_from_jsonv() takes ownership of %p arguments. On failure, we
can't generally know whether we failed before or after %p, so
ownership becomes indeterminate. To avoid leaks, callers passing %p
must terminate on error, e.g. by passing &error_abort. Trap for the
unwary; document and give the function internal linkage.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180806065344.7103-11-armbru@redhat.com>
Diffstat (limited to 'include/qapi')
| -rw-r--r-- | include/qapi/qmp/qjson.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/qapi/qmp/qjson.h b/include/qapi/qmp/qjson.h index dce7858..5ebbe5a 100644 --- a/include/qapi/qmp/qjson.h +++ b/include/qapi/qmp/qjson.h @@ -15,8 +15,6 @@ #define QJSON_H QObject *qobject_from_json(const char *string, Error **errp); -QObject *qobject_from_jsonv(const char *string, va_list *ap, Error **errp) - GCC_FMT_ATTR(1, 0); QObject *qobject_from_vjsonf_nofail(const char *string, va_list ap) GCC_FMT_ATTR(1, 0); |