diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2013-08-20 00:35:38 +0200 |
|---|---|---|
| committer | Luiz Capitulino <lcapitulino@redhat.com> | 2013-08-20 11:52:00 -0400 |
| commit | 15a849be100b54776bcf63193c3fea598666030f (patch) | |
| tree | f41db9777be6929ef8052c2d8a92fab294873935 /include/qapi | |
| parent | 581a8a800070500527f6c75e5d6b75134c2b5a9d (diff) | |
| download | qemu-15a849be100b54776bcf63193c3fea598666030f.zip qemu-15a849be100b54776bcf63193c3fea598666030f.tar.gz qemu-15a849be100b54776bcf63193c3fea598666030f.tar.bz2 | |
OptsVisitor: don't try to flatten overlong integer ranges
Prevent mistyped command line options from incurring high memory and CPU
usage at startup. 64K elements in a range should be enough for everyone
(TM).
The OPTS_VISITOR_RANGE_MAX macro is public so that unit tests can
construct corner cases with it.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'include/qapi')
| -rw-r--r-- | include/qapi/opts-visitor.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/include/qapi/opts-visitor.h b/include/qapi/opts-visitor.h index 5939eee..fd48c14 100644 --- a/include/qapi/opts-visitor.h +++ b/include/qapi/opts-visitor.h @@ -16,6 +16,12 @@ #include "qapi/visitor.h" #include "qemu/option.h" +/* Inclusive upper bound on the size of any flattened range. This is a safety + * (= anti-annoyance) measure; wrong ranges should not cause long startup + * delays nor exhaust virtual memory. + */ +#define OPTS_VISITOR_RANGE_MAX 65536 + typedef struct OptsVisitor OptsVisitor; /* Contrarily to qemu-option.c::parse_option_number(), OptsVisitor's "int" |