diff options
author | Greg Kurz <gkurz@linux.vnet.ibm.com> | 2016-05-04 21:44:19 +0200 |
---|---|---|
committer | Amit Shah <amit.shah@redhat.com> | 2016-05-23 21:44:08 +0530 |
commit | 24f3902b088cd4f2dbebfd90527b5d81d6a050e9 (patch) | |
tree | 86a48cceddb52cbf944f4d05ab3ff30d759cd7d1 /include/migration | |
parent | d85a31d1f4d45462b7ca333190b5d14fad982f3e (diff) | |
download | qemu-24f3902b088cd4f2dbebfd90527b5d81d6a050e9.zip qemu-24f3902b088cd4f2dbebfd90527b5d81d6a050e9.tar.gz qemu-24f3902b088cd4f2dbebfd90527b5d81d6a050e9.tar.bz2 |
savevm: fail if migration blockers are present
QEMU has currently two ways to prevent migration to occur:
- migration blocker when it depends on runtime state
- VMStateDescription.unmigratable when migration is not supported at all
This patch gathers all the logic into a single function to be called from
both the savevm and the migrate paths.
This fixes a bug with 9p, at least, where savevm would succeed and the
following would happen in the guest after loadvm:
$ ls /host
ls: cannot access /host: Protocol error
With this patch:
(qemu) savevm foo
Migration is disabled when VirtFS export path '/' is mounted in the guest
using mount_tag 'host'
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <146239057139.11271.9011797645454781543.stgit@bahia.huguette.org>
[Update subject according to Paolo's suggestion - Amit]
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Diffstat (limited to 'include/migration')
-rw-r--r-- | include/migration/migration.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/migration/migration.h b/include/migration/migration.h index ac2c12c..9e36a97 100644 --- a/include/migration/migration.h +++ b/include/migration/migration.h @@ -210,6 +210,7 @@ int migrate_fd_close(MigrationState *s); void add_migration_state_change_notifier(Notifier *notify); void remove_migration_state_change_notifier(Notifier *notify); MigrationState *migrate_init(const MigrationParams *params); +bool migration_is_blocked(Error **errp); bool migration_in_setup(MigrationState *); bool migration_has_finished(MigrationState *); bool migration_has_failed(MigrationState *); |