diff options
| author | Alex Bennée <alex.bennee@linaro.org> | 2022-08-02 10:49:58 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2022-10-07 09:41:51 -0400 |
| commit | 9f6bcfd99f46377888059d8539befec9505f57fb (patch) | |
| tree | 7ebee167ba59b63f6c9058217b0f86c1336cd547 /include/hw/virtio | |
| parent | a27612311988aff8f29a68ed5eaecde3bf6cdf99 (diff) | |
| download | qemu-9f6bcfd99f46377888059d8539befec9505f57fb.zip qemu-9f6bcfd99f46377888059d8539befec9505f57fb.tar.gz qemu-9f6bcfd99f46377888059d8539befec9505f57fb.tar.bz2 | |
hw/virtio: move vm_running check to virtio_device_started
All the boilerplate virtio code does the same thing (or should at
least) of checking to see if the VM is running before attempting to
start VirtIO. Push the logic up to the common function to avoid
getting a copy and paste wrong.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220802095010.3330793-11-alex.bennee@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include/hw/virtio')
| -rw-r--r-- | include/hw/virtio/virtio.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index 9bb2485..74e7ad5 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -100,6 +100,7 @@ struct VirtIODevice VirtQueue *vq; MemoryListener listener; uint16_t device_id; + /* @vm_running: current VM running state via virtio_vmstate_change() */ bool vm_running; bool broken; /* device in invalid state, needs reset */ bool use_disabled_flag; /* allow use of 'disable' flag when needed */ @@ -376,6 +377,10 @@ static inline bool virtio_device_started(VirtIODevice *vdev, uint8_t status) return vdev->started; } + if (!vdev->vm_running) { + return false; + } + return status & VIRTIO_CONFIG_S_DRIVER_OK; } |