aboutsummaryrefslogtreecommitdiff
path: root/include/hw/mem
diff options
context:
space:
mode:
authorXiao Guangrong <guangrong.xiao@linux.intel.com>2016-11-07 19:13:37 +0800
committerMichael S. Tsirkin <mst@redhat.com>2016-11-15 17:20:37 +0200
commit12f86b5b3e1bdf75e0a467d771c16cc42f3a1f1a (patch)
tree5d4c9dedb0e4cf8267f817e75872a5234f9d6f3d /include/hw/mem
parentc7f8d0f3a52b5ef8fdcd305cce438f67d7e06a9f (diff)
downloadqemu-12f86b5b3e1bdf75e0a467d771c16cc42f3a1f1a.zip
qemu-12f86b5b3e1bdf75e0a467d771c16cc42f3a1f1a.tar.gz
qemu-12f86b5b3e1bdf75e0a467d771c16cc42f3a1f1a.tar.bz2
nvdimm acpi: drop the lock of fit buffer
as there is a global lock to protect vm-exit handlers and QMP/monitor, this lock can be dropped Suggested-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Diffstat (limited to 'include/hw/mem')
-rw-r--r--include/hw/mem/nvdimm.h17
1 files changed, 5 insertions, 12 deletions
diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h
index 33cd421..d3ffb25 100644
--- a/include/hw/mem/nvdimm.h
+++ b/include/hw/mem/nvdimm.h
@@ -99,20 +99,13 @@ typedef struct NVDIMMClass NVDIMMClass;
#define NVDIMM_ACPI_IO_LEN 4
/*
- * The buffer, @fit, saves the FIT info for all the presented NVDIMM
- * devices which is updated after the NVDIMM device is plugged or
- * unplugged.
- *
- * Rules to use the buffer:
- * 1) the user should hold the @lock to access the buffer.
- * 2) mark @dirty whenever the buffer is updated.
- *
- * These rules preserve NVDIMM ACPI _FIT method to read incomplete
- * or obsolete fit info if fit update happens during multiple RFIT
- * calls.
+ * NvdimmFitBuffer:
+ * @fit: FIT structures for present NVDIMMs. It is updated when
+ * the NVDIMM device is plugged or unplugged.
+ * @dirty: It allows OSPM to detect change and restart read in
+ * progress if there is any.
*/
struct NvdimmFitBuffer {
- QemuMutex lock;
GArray *fit;
bool dirty;
};