diff options
| author | Dr. David Alan Gilbert <dgilbert@redhat.com> | 2022-04-06 14:58:12 -0400 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2022-04-06 20:03:26 +0100 |
| commit | a83c2844903c45aa7d32cdd17305f23ce2c56ab9 (patch) | |
| tree | 9eea3924e2fe01b6973cdb443a64aee8ae3011b1 /include/hw/acpi | |
| parent | f53faa70bb63cc0c8e2fd0752b7ad2c8a79616ba (diff) | |
| download | qemu-a83c2844903c45aa7d32cdd17305f23ce2c56ab9.zip qemu-a83c2844903c45aa7d32cdd17305f23ce2c56ab9.tar.gz qemu-a83c2844903c45aa7d32cdd17305f23ce2c56ab9.tar.bz2 | |
acpi: fix acpi_index migration
vmstate_acpi_pcihp_use_acpi_index() was expecting AcpiPciHpState
as state but it actually received PIIX4PMState, because
VMSTATE_PCI_HOTPLUG is a macro and not another struct.
So it ended up accessing random pointer, which resulted
in 'false' return value and acpi_index field wasn't ever
sent.
However in 7.0 that pointer de-references to value > 0, and
destination QEMU starts to expect the field which isn't
sent in migratioon stream from older QEMU (6.2 and older).
As result migration fails with:
qemu-system-x86_64: Missing section footer for 0000:00:01.3/piix4_pm
qemu-system-x86_64: load of migration failed: Invalid argument
In addition with QEMU-6.2, destination due to not expected
state, also never expects the acpi_index field in migration
stream.
Q35 is not affected as it always sends/expects the field as
long as acpi based PCI hotplug is enabled.
Fix issue by introducing compat knob to never send/expect
acpi_index in migration stream for 6.2 and older PC machine
types and always send it for 7.0 and newer PC machine types.
Diagnosed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Fixes: b32bd76 ("pci: introduce acpi-index property for PCI device")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/932
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'include/hw/acpi')
| -rw-r--r-- | include/hw/acpi/pcihp.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/hw/acpi/pcihp.h b/include/hw/acpi/pcihp.h index af1a169..7e268c2 100644 --- a/include/hw/acpi/pcihp.h +++ b/include/hw/acpi/pcihp.h @@ -73,8 +73,6 @@ void acpi_pcihp_reset(AcpiPciHpState *s, bool acpihp_root_off); extern const VMStateDescription vmstate_acpi_pcihp_pci_status; -bool vmstate_acpi_pcihp_use_acpi_index(void *opaque, int version_id); - #define VMSTATE_PCI_HOTPLUG(pcihp, state, test_pcihp, test_acpi_index) \ VMSTATE_UINT32_TEST(pcihp.hotplug_select, state, \ test_pcihp), \ |