diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2023-09-11 11:46:19 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-09-20 17:46:01 +0200 |
| commit | 32a8aba37eaae54d3a0a7ae5e93e3e157525660a (patch) | |
| tree | c310d966906d71c635c89425f2e1f314dfafdba9 /include/block | |
| parent | ede01e4635050a395eacd57b7d7fbea8ea208704 (diff) | |
| download | qemu-32a8aba37eaae54d3a0a7ae5e93e3e157525660a.zip qemu-32a8aba37eaae54d3a0a7ae5e93e3e157525660a.tar.gz qemu-32a8aba37eaae54d3a0a7ae5e93e3e157525660a.tar.bz2 | |
block: Mark bdrv_unref_child() GRAPH_WRLOCK
Instead of taking the writer lock internally, require callers to already
hold it when calling bdrv_unref_child(). These callers will typically
already hold the graph lock once the locking work is completed, which
means that they can't call functions that take it internally.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20230911094620.45040-21-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include/block')
| -rw-r--r-- | include/block/block-global-state.h | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/include/block/block-global-state.h b/include/block/block-global-state.h index eb12a35..0f6df8f 100644 --- a/include/block/block-global-state.h +++ b/include/block/block-global-state.h @@ -225,7 +225,12 @@ void bdrv_ref(BlockDriverState *bs); void no_coroutine_fn bdrv_unref(BlockDriverState *bs); void coroutine_fn no_co_wrapper bdrv_co_unref(BlockDriverState *bs); void GRAPH_WRLOCK bdrv_schedule_unref(BlockDriverState *bs); -void bdrv_unref_child(BlockDriverState *parent, BdrvChild *child); + +void GRAPH_WRLOCK +bdrv_unref_child(BlockDriverState *parent, BdrvChild *child); + +void coroutine_fn no_co_wrapper_bdrv_wrlock +bdrv_co_unref_child(BlockDriverState *parent, BdrvChild *child); BdrvChild * GRAPH_WRLOCK bdrv_attach_child(BlockDriverState *parent_bs, |