diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2023-09-29 16:51:53 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-10-12 16:31:33 +0200 |
| commit | 018f9dea9c905506c49f8f37c018470dddfc50f1 (patch) | |
| tree | 8eba2e1c435943d380b423301114ca415608d5b7 /include/block | |
| parent | 277f2007ce187a6ff467579cb016824f80a2be10 (diff) | |
| download | qemu-018f9dea9c905506c49f8f37c018470dddfc50f1.zip qemu-018f9dea9c905506c49f8f37c018470dddfc50f1.tar.gz qemu-018f9dea9c905506c49f8f37c018470dddfc50f1.tar.bz2 | |
block: Mark bdrv_apply_auto_read_only() and callers GRAPH_RDLOCK
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_apply_auto_read_only() need to hold a reader lock for the graph
because it calls bdrv_can_set_read_only(), which indirectly accesses the
parents list of a node.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20230929145157.45443-19-kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include/block')
| -rw-r--r-- | include/block/block-io.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/include/block/block-io.h b/include/block/block-io.h index 2c0c7b1..e051e9b 100644 --- a/include/block/block-io.h +++ b/include/block/block-io.h @@ -163,8 +163,10 @@ bdrv_is_allocated_above(BlockDriverState *bs, BlockDriverState *base, int coroutine_fn GRAPH_RDLOCK bdrv_co_is_zero_fast(BlockDriverState *bs, int64_t offset, int64_t bytes); -int bdrv_apply_auto_read_only(BlockDriverState *bs, const char *errmsg, - Error **errp); +int GRAPH_RDLOCK +bdrv_apply_auto_read_only(BlockDriverState *bs, const char *errmsg, + Error **errp); + bool bdrv_is_read_only(BlockDriverState *bs); bool bdrv_is_writable(BlockDriverState *bs); bool bdrv_is_sg(BlockDriverState *bs); |