diff options
author | Peter Xu <peterx@redhat.com> | 2024-10-24 17:30:52 -0400 |
---|---|---|
committer | Peter Xu <peterx@redhat.com> | 2024-10-31 15:48:18 -0400 |
commit | f018eb62b2bb7618b0cb8a796ac4b76fd786ecaf (patch) | |
tree | 6d93fec9312cea0071a58734b720dd46b22fdbfc /hw | |
parent | 64dcd2c9c627b88ec7d071e1b49f0180b467fc71 (diff) | |
download | qemu-f018eb62b2bb7618b0cb8a796ac4b76fd786ecaf.zip qemu-f018eb62b2bb7618b0cb8a796ac4b76fd786ecaf.tar.gz qemu-f018eb62b2bb7618b0cb8a796ac4b76fd786ecaf.tar.bz2 |
migration: Drop migration_is_setup_or_active()
This helper is mostly the same as migration_is_running(), except that one
has COLO reported as true, the other has CANCELLING reported as true.
Per my past years experience on the state changes, none of them should
matter.
To make it slightly safer, report both COLO || CANCELLING to be true in
migration_is_running(), then drop the other one. We kept the 1st only
because the name is simpler, and clear enough.
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20241024213056.1395400-5-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'hw')
-rw-r--r-- | hw/vfio/common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 36d0cf6..dcef44f 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -149,7 +149,7 @@ bool vfio_viommu_preset(VFIODevice *vbasedev) static void vfio_set_migration_error(int ret) { - if (migration_is_setup_or_active()) { + if (migration_is_running()) { migration_file_set_error(ret, NULL); } } |